Add nightly dependency bump workflow #479

ezhang6811 · 2025-09-23T01:59:37Z

Issue #, if available:

Description of changes:
Add a workflow nightly-build.yml with following actions:

creates or checks out existing nightly-dependency-updates branch
checks for newest versions of dependencies in opentelemetry-python and opentelemetry-python-contrib, bumps versions if applicable, and creates/updates PR
search for releases with breaking changes in release notes, and links in the PR
runs main build checks on the branch, publishes a failure metric based on the outcome.

Example nightly build PR: #484

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ezhang6811 · 2025-09-23T19:51:49Z

I just realized: I updated main build so that it also triggers when pushes are made to the nightly-dependency-updates branch so that updates to the nightly build PR can trigger main build again. If this is the case, do we even need to run main build in the nightly build workflow itself, or is that redundant?

This reverts commit 076e529.

thpierce

Not a complete review, just some initial thoughts.

.github/workflows/nightly-build.yml

.github/workflows/main-build.yml

aws-opentelemetry-distro/pyproject.toml

scripts/update_dependencies.py

This reverts commit 957024b.

This reverts commit 076e529.

This reverts commit bb66be4.

This reverts commit 692abde.

thpierce · 2025-10-07T18:12:05Z

.github/workflows/main-build.yml

+        with:
+          ref: ${{ inputs.ref || github.sha }}


Why github.sha? Is there no github.ref? Just a bit unclear why this is correct.

thpierce · 2025-10-07T18:13:28Z

.github/workflows/main-build.yml

    needs: [ build, application-signals-e2e-test ]
    runs-on: ubuntu-latest
-    if: always()
+    if: always() && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/'))


Do we still need always()? Also release/v I think.

Suggested change

if: always() && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/'))

if: (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/v'))

How did we confirm that refs/heads/main is correct?

thpierce · 2025-10-07T19:58:46Z

.github/workflows/nightly-build.yml

@@ -0,0 +1,147 @@
+name: Nightly Upstream Snapshot Build


Lets add a description

thpierce · 2025-10-07T20:01:06Z

.github/workflows/nightly-build.yml

+    - name: Set up Python
+      uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #v6.0.0
+      with:
+        python-version: '3.11'


thpierce · 2025-10-07T20:03:43Z

.github/workflows/nightly-build.yml

+        OTEL_PYTHON_VERSION: ${{ steps.get_versions.outputs.otel_python_version }}
+        OTEL_CONTRIB_VERSION: ${{ steps.get_versions.outputs.otel_contrib_version }}


Interesting, does that work? I didn't realize a script could send outputs to the GH action like this. Just want to confirm we tested this.

thpierce · 2025-10-07T21:03:24Z

scripts/find_breaking_changes.py

+
+            # Check if this release is between current and new version
+            try:
+                if version.parse(release_version) > version.parse(current_version) and version.parse(


Sanity check: Does this handle patch versions well? Would like to see a bit of testing here, can just be a manual thing.

thpierce · 2025-10-07T21:05:28Z

scripts/find_breaking_changes.py

+                    if any(
+                        keyword in body for keyword in ["breaking change", "breaking changes", "breaking:", "breaking"]
+                    ):


What's this based on?

Does this work for [BREAKING], which I saw here?

thpierce · 2025-10-07T21:06:12Z

scripts/find_breaking_changes.py

+                            }
+                        )
+            except (ValueError, KeyError):
+                # Skip releases with invalid version formats or missing data


Lets at least log it.

thpierce · 2025-10-07T21:06:30Z

scripts/find_breaking_changes.py

+    except requests.RequestException as request_error:
+        print(f"Warning: Could not get releases for {repo}: {request_error}")
+        return []


Should we fail?

thpierce · 2025-10-07T21:07:04Z

.github/workflows/nightly-build.yml

+        **Upstream releases with breaking changes:**
+        ${{ steps.breaking_changes.outputs.breaking_changes_info }}"


Elaborate just a bit - callout this is not a perfect system and say what we are looking for.

ezhang6811 added 11 commits September 22, 2025 17:55

add nightly build with scripts

e74800c

add otlp exporter dependency

7252cb3

create PR earlier

e56456b

add test branch

c2d895d

remove dependencies label

6cc475d

only push to one branch

e9c78dd

add BRANCH_NAME var

7349738

update dependency update script

ca80bbb

fix checkout

cdbfea2

exit workflow early

feb2005

update independent dependency versions

d9d2dfe

ezhang6811 requested a review from a team as a code owner September 23, 2025 01:59

ezhang6811 added 4 commits September 22, 2025 19:06

update comments

e2a6c4c

call main build directly from nightly build

b074e69

comment fix

3fb046f

lint fixes

351813e

ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label Sep 23, 2025

ezhang6811 added 9 commits September 22, 2025 19:30

use SHAs instead of versions for actions

9d57171

lint

9f0ebbb

lint fixes

60b627a

more lint

1544468

more lint

a6d58c1

add headers to python scripts

e84deb6

remove push trigger

51a9ee0

call main build on nightly build branch

957024b

add test branch to push to

076e529

Revert "add test branch to push to"

30d7d0a

This reverts commit 076e529.

thpierce reviewed Sep 24, 2025

View reviewed changes

remove extra dependency

f3b7a09

ezhang6811 added 21 commits September 24, 2025 10:35

always checkout branch and update

5182877

Revert "call main build on nightly build branch"

9efd150

This reverts commit 957024b.

add links to breaking changes in PR

5ebbe34

add push trigger for testing

1b56b75

check breaking changes before updating

2f26b9c

update PR for existing branch

0329b09

update PR correctly if new breaking changes are found

4db8d3e

fix PR formatting

84706be

search for open PR in branch

d9d3a9a

PR format fix

1357fc8

publish metric for nightly build failures

74c6fb4

add permission to configure AWS credentials

f5ba036

add write and pr permissions

8b05265

Revert "add test branch to push to"

dda3ac0

This reverts commit 076e529.

lint fixes for breaking changes script

63b72f3

lint fix

1c7bdf3

check for breaking changes as headers

bb66be4

test trigger

692abde

Revert "check for breaking changes as headers"

12cc0e5

This reverts commit bb66be4.

Revert "test trigger"

e7fb5f7

This reverts commit 692abde.

lint fix

15e4550

thpierce reviewed Oct 7, 2025

View reviewed changes

address minor PR comments

b1b4a87

	if: always() && (github.ref == 'refs/heads/main' \|\| startsWith(github.ref, 'refs/heads/release/'))
	if: (github.ref == 'refs/heads/main' \|\| startsWith(github.ref, 'refs/heads/release/v'))

		OTEL_PYTHON_VERSION: ${{ steps.get_versions.outputs.otel_python_version }}
		OTEL_CONTRIB_VERSION: ${{ steps.get_versions.outputs.otel_contrib_version }}

		Upstream releases with breaking changes:
		${{ steps.breaking_changes.outputs.breaking_changes_info }}"

Add nightly dependency bump workflow #479

Are you sure you want to change the base?

Add nightly dependency bump workflow #479

Uh oh!

Conversation

ezhang6811 commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezhang6811 commented Sep 23, 2025

Uh oh!

thpierce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ezhang6811 commented Sep 23, 2025 •

edited

Loading